Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): use agent image for initcontainer #38

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

starbops
Copy link
Member

@starbops starbops commented Nov 6, 2024

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:

The dhcp-agent pod's init container is using the docker.io/library/busybox:latest image. The image is not packed in the ISO image we shipped, so it'll cause trouble when users enable the harvester-vm-dhcp-controller add-on in air-gapped Harvester clusters.

Solution:

Instead of using docker.io/library/busybox:latest to configure the dhcp-agent pod's IP address, use docker.io/rancher/harvester-vm-dhcp-agent:<tag> as the new image. Because of that, we need to add the iproute2 package into the agent image.

Related Issue:

harvester/harvester#6942

Test plan:

  1. Install the harvester-vm-dhcp-controller experimental add-on
  2. Enable the add-on
  3. Create an IPPool object
  4. Ensure the IPPool object's conditions are all good, especially the AgentReady one
  5. Create a VM
  6. Ensure the VM gets the IP address recorded in the corresponding VirtualMachineNetworkConfig object

@starbops starbops marked this pull request as ready for review November 6, 2024 10:23
Signed-off-by: Zespre Chang <zespre.chang@suse.com>
Copy link

@ihcsim ihcsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@starbops starbops requested a review from bk201 November 7, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants